NTB: perf: Fix an error code in perf_setup_inbuf()
authorYang Li <yang.lee@linux.alibaba.com>
Mon, 7 Jun 2021 08:40:36 +0000 (16:40 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 22 Sep 2021 10:28:02 +0000 (12:28 +0200)
[ Upstream commit 0097ae5f7af5684f961a5f803ff7ad3e6f933668 ]

When the function IS_ALIGNED() returns false, the value of ret is 0.
So, we set ret to -EINVAL to indicate this error.

Clean up smatch warning:
drivers/ntb/test/ntb_perf.c:602 perf_setup_inbuf() warn: missing error
code 'ret'.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Reviewed-by: Serge Semin <fancer.lancer@gmail.com>
Signed-off-by: Jon Mason <jdmason@kudzu.us>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/ntb/test/ntb_perf.c

index 89df1350fefd8d6e7642491aeb0b7731490d0df5..65e1e5cf1b29a6dd0b0573e263f273d7644c2754 100644 (file)
@@ -598,6 +598,7 @@ static int perf_setup_inbuf(struct perf_peer *peer)
                return -ENOMEM;
        }
        if (!IS_ALIGNED(peer->inbuf_xlat, xlat_align)) {
+               ret = -EINVAL;
                dev_err(&perf->ntb->dev, "Unaligned inbuf allocated\n");
                goto err_free_inbuf;
        }