Fixed misplaced goto in http.c
authorGiuseppe Baccini <giuseppe.baccini@suse.com>
Tue, 19 Jul 2022 07:39:46 +0000 (09:39 +0200)
committerGiuseppe Baccini <giuseppe.baccini@suse.com>
Tue, 19 Jul 2022 07:39:46 +0000 (09:39 +0200)
- In http.c:fio_http_queue function, when the user specifies rw=write
  and if curl_easy_perform fails then the control reaches line 565 and
  incorrectly prints: "WARNING: Only DDIR_READ/DDIR_WRITE/DDIR_TRIM are
supported!".
  Fix to this consists in moving statement: "goto err" at the end of the
  block as already has been done for trim/read blocks.

Signed-off-by: Giuseppe Baccini <giuseppe.baccini@suse.com>
engines/http.c

index 696febe15105784e505847ef2f12d6071c0bbd97..b6df70f8d8a8e461632f7caf5af5bfd8157b0e30 100644 (file)
@@ -526,8 +526,8 @@ static enum fio_q_status fio_http_queue(struct thread_data *td,
                        if (status == 100 || (status >= 200 && status <= 204))
                                goto out;
                        log_err("DDIR_WRITE failed with HTTP status code %ld\n", status);
-                       goto err;
                }
+               goto err;
        } else if (io_u->ddir == DDIR_READ) {
                curl_easy_setopt(http->curl, CURLOPT_READDATA, NULL);
                curl_easy_setopt(http->curl, CURLOPT_WRITEDATA, &_curl_stream);