sunrpc: destroy rpc_inode_cachep after unregister_filesystem
authorDan Aloni <dan@kernelim.com>
Fri, 26 Jun 2020 07:23:16 +0000 (10:23 +0300)
committerTrond Myklebust <trond.myklebust@hammerspace.com>
Fri, 17 Jul 2020 17:12:44 +0000 (13:12 -0400)
Better to unregister the file system before destroying the kmem_cache
cache of the inodes, so that the inodes are freed before we are trying
to destroy it. Otherwise, kmem_cache yells that some objects are live.

Signed-off-by: Dan Aloni <dan@kernelim.com>
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
net/sunrpc/rpc_pipe.c

index e9d0953522f09d38683863cf966ec397b62e5af3..eadc0ede928c320a7afae33e1821d7e1ce63f246 100644 (file)
@@ -1510,6 +1510,6 @@ err_notifier:
 void unregister_rpc_pipefs(void)
 {
        rpc_clients_notifier_unregister();
-       kmem_cache_destroy(rpc_inode_cachep);
        unregister_filesystem(&rpc_pipe_fs_type);
+       kmem_cache_destroy(rpc_inode_cachep);
 }