projects
/
linux-block.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
8728483
)
ASoC: da7213: Initialize the mutex
author
Claudiu Beznea
<claudiu.beznea.uj@bp.renesas.com>
Thu, 23 Jan 2025 12:10:36 +0000
(14:10 +0200)
committer
Mark Brown
<broonie@kernel.org>
Thu, 23 Jan 2025 13:12:46 +0000
(13:12 +0000)
Initialize the struct da7213_priv::ctrl_lock mutex. Without it the
following stack trace is displayed when rebooting and lockdep is enabled:
DEBUG_LOCKS_WARN_ON(lock->magic != lock)
WARNING: CPU: 0 PID: 180 at kernel/locking/mutex.c:564 __mutex_lock+0x254/0x4e4
CPU: 0 UID: 0 PID: 180 Comm: alsactl Not tainted
6.13.0-next-20250123-arm64-renesas-00002-g132083a22d3d
#30
Hardware name: Renesas SMARC EVK version 2 based on r9a08g045s33 (DT)
pstate:
60400005
(nZCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--)
pc : __mutex_lock+0x254/0x4e4
lr : __mutex_lock+0x254/0x4e4
sp :
ffff800082c13c00
x29:
ffff800082c13c00
x28:
ffff00001002b500
x27:
0000000000000000
x26:
0000000000000000
x25:
ffff800080b30db4
x24:
0000000000000002
x23:
ffff800082c13c70
x22:
0000ffffc2a68a70
x21:
ffff000010348000
x20:
0000000000000000
x19:
ffff00000be2e488
x18:
0000000000000000
x17:
0000000000000000
x16:
0000000000000000
x15:
0000000000000000
x14:
00000000000003c1
x13:
00000000000003c1
x12:
0000000000000000
x11:
0000000000000011
x10:
0000000000001420
x9 :
ffff800082c13a70
x8 :
0000000000000001
x7 :
ffff800082c13a50
x6 :
ffff800082c139e0
x5 :
ffff800082c14000
x4 :
ffff800082c13a50
x3 :
0000000000000000
x2 :
0000000000000000
x1 :
0000000000000000
x0 :
ffff00001002b500
Call trace:
__mutex_lock+0x254/0x4e4 (P)
mutex_lock_nested+0x20/0x28
da7213_volsw_locked_get+0x34/0x60
snd_ctl_elem_read+0xbc/0x114
snd_ctl_ioctl+0x878/0xa70
__arm64_sys_ioctl+0x94/0xc8
invoke_syscall+0x44/0x104
el0_svc_common.constprop.0+0xb4/0xd4
do_el0_svc+0x18/0x20
el0_svc+0x3c/0xf0
el0t_64_sync_handler+0xc0/0xc4
el0t_64_sync+0x154/0x158
irq event stamp: 7713
hardirqs last enabled at (7713): [<
ffff800080170d94
>] ktime_get_coarse_real_ts64+0xf0/0x10c
hardirqs last disabled at (7712): [<
ffff800080170d58
>] ktime_get_coarse_real_ts64+0xb4/0x10c
softirqs last enabled at (7550): [<
ffff8000800179d4
>] fpsimd_restore_current_state+0x30/0xb8
softirqs last disabled at (7548): [<
ffff8000800179a8
>] fpsimd_restore_current_state+0x4/0xb8
---[ end trace
0000000000000000
]---
Fixes:
64c3259b5f86
("ASoC: da7213: Add new kcontrol for tonegen")
Cc: stable@vger.kernel.org
Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Link:
https://patch.msgid.link/20250123121036.70406-1-claudiu.beznea.uj@bp.renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/da7213.c
patch
|
blob
|
blame
|
history
diff --git
a/sound/soc/codecs/da7213.c
b/sound/soc/codecs/da7213.c
index ca4cc954efa8e657c32cb920ba8a264ca5d23880..eb97ac73ec0624c91a015aa388513aa385f7aca7 100644
(file)
--- a/
sound/soc/codecs/da7213.c
+++ b/
sound/soc/codecs/da7213.c
@@
-2203,6
+2203,8
@@
static int da7213_i2c_probe(struct i2c_client *i2c)
return ret;
}
+ mutex_init(&da7213->ctrl_lock);
+
pm_runtime_set_autosuspend_delay(&i2c->dev, 100);
pm_runtime_use_autosuspend(&i2c->dev);
pm_runtime_set_active(&i2c->dev);