mt76: mt7615: fix memory leak in mt7615_coredump_work
authorLorenzo Bianconi <lorenzo@kernel.org>
Fri, 19 Feb 2021 17:22:11 +0000 (18:22 +0100)
committerFelix Fietkau <nbd@nbd.name>
Sun, 11 Apr 2021 22:01:21 +0000 (00:01 +0200)
Similar to the issue fixed in mt7921_coredump_work, fix a possible memory
leak in mt7615_coredump_work routine.

Fixes: d2bf7959d9c0f ("mt76: mt7663: introduce coredump support")
Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
Signed-off-by: Felix Fietkau <nbd@nbd.name>
drivers/net/wireless/mediatek/mt76/mt7615/mac.c

index f2dd56674acbee801fe2ecb1c69a01c55de3cfd5..d2ef2b33e2b5c6506dd56c1ae2585e349a4085b6 100644 (file)
@@ -2352,8 +2352,10 @@ void mt7615_coredump_work(struct work_struct *work)
                        break;
 
                skb_pull(skb, sizeof(struct mt7615_mcu_rxd));
-               if (data + skb->len - dump > MT76_CONNAC_COREDUMP_SZ)
-                       break;
+               if (data + skb->len - dump > MT76_CONNAC_COREDUMP_SZ) {
+                       dev_kfree_skb(skb);
+                       continue;
+               }
 
                memcpy(data, skb->data, skb->len);
                data += skb->len;