Input: synaptics - hide unused smbus_pnp_ids[] array
authorArnd Bergmann <arnd@arndb.de>
Tue, 25 Feb 2025 20:25:35 +0000 (12:25 -0800)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Tue, 25 Feb 2025 20:58:41 +0000 (12:58 -0800)
When SMBUS is disabled, this is never referenced, causing a W=1 warning:

drivers/input/mouse/synaptics.c:164:27: error: 'smbus_pnp_ids' defined but not used [-Werror=unused-const-variable=]

Hide the array behind the same #ifdef as the code referencing it.

Fixes: e839ffab0289 ("Input: synaptics - add support for Intertouch devices")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/20250225145451.1141995-1-arnd@kernel.org
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/mouse/synaptics.c

index aba57abe6978828ec39d5393105ff65f93c5e9e8..309c360aab5597d0982807007695cf8c1912fe3c 100644 (file)
@@ -161,6 +161,7 @@ static const char * const topbuttonpad_pnp_ids[] = {
        NULL
 };
 
+#ifdef CONFIG_MOUSE_PS2_SYNAPTICS_SMBUS
 static const char * const smbus_pnp_ids[] = {
        /* all of the topbuttonpad_pnp_ids are valid, we just add some extras */
        "LEN0048", /* X1 Carbon 3 */
@@ -196,6 +197,7 @@ static const char * const smbus_pnp_ids[] = {
        "SYN3257", /* HP Envy 13-ad105ng */
        NULL
 };
+#endif
 
 static const char * const forcepad_pnp_ids[] = {
        "SYN300D",