gpio: Remove VLA from MAX3191X driver

The new challenge is to remove VLAs from the kernel
(see https://lkml.org/lkml/2018/3/7/621)

This patch replaces several a VLA with an appropriate call to
kmalloc_array.

Signed-off-by: Laura Abbott <labbott@redhat.com>
Reviewed-and-tested-by: Lukas Wunner <lukas@wunner.de>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

diff --git a/drivers/gpio/gpio-max3191x.c b/drivers/gpio/gpio-max3191x.c
index f74b1072e84b68f36c54af8cdb1dc74812bb62ca..b5b9cb1fda5090780302a0a5074f8bc7972894c6 100644 (file)
--- a/drivers/gpio/gpio-max3191x.c
+++ b/drivers/gpio/gpio-max3191x.c
@@ -315,12 +315,17 @@ static void gpiod_set_array_single_value_cansleep(unsigned int ndescs,
                                                  struct gpio_desc **desc,
                                                  int value)
 {
-       int i, values[ndescs];
+       int i, *values;
+
+       values = kmalloc_array(ndescs, sizeof(*values), GFP_KERNEL);
+       if (!values)
+               return;
 
        for (i = 0; i < ndescs; i++)
                values[i] = value;
 
        gpiod_set_array_value_cansleep(ndescs, desc, values);
+       kfree(values);
 }
 
 static struct gpio_descs *devm_gpiod_get_array_optional_count(