scsi: aic94xx: Fix fall-through warnings for Clang

In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
warnings by explicitly adding a couple of break and fallthrough statements
instead of just letting the code fall through to the next case.

Link: https://github.com/KSPP/linux/issues/115
Link: https://lore.kernel.org/r/9b58459045d303bbea0160f2e349f5799402a2bf.1605896059.git.gustavoars@kernel.org
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

diff --git a/drivers/scsi/aic94xx/aic94xx_scb.c b/drivers/scsi/aic94xx/aic94xx_scb.c
index e2d880a5f391535cc9fb37f1bac604ac6280c401..13677973da5cf9b5911b1138e8207ed0e0cbf783 100644 (file)
--- a/drivers/scsi/aic94xx/aic94xx_scb.c
+++ b/drivers/scsi/aic94xx/aic94xx_scb.c
@@ -721,6 +721,7 @@ static void set_speed_mask(u8 *speed_mask, struct asd_phy_desc *pd)
                fallthrough;
        case SAS_LINK_RATE_3_0_GBPS:
                *speed_mask |= SAS_SPEED_15_DIS;
+               fallthrough;
        default:
        case SAS_LINK_RATE_1_5_GBPS:
                /* nothing to do */
@@ -739,6 +740,7 @@ static void set_speed_mask(u8 *speed_mask, struct asd_phy_desc *pd)
        switch (pd->min_sata_lrate) {
        case SAS_LINK_RATE_3_0_GBPS:
                *speed_mask |= SATA_SPEED_15_DIS;
+               fallthrough;
        default:
        case SAS_LINK_RATE_1_5_GBPS:
                /* nothing to do */

diff --git a/drivers/scsi/aic94xx/aic94xx_task.c b/drivers/scsi/aic94xx/aic94xx_task.c
index ed034192b3c3a71278d1c0957aad79bf1886f9a0..71d18f607dae0d919fff466d964a461c58e1a0d2 100644 (file)
--- a/drivers/scsi/aic94xx/aic94xx_task.c
+++ b/drivers/scsi/aic94xx/aic94xx_task.c
@@ -315,6 +315,7 @@ Again:
                break;
        case SAS_PROTOCOL_SSP:
                asd_unbuild_ssp_ascb(ascb);
+               break;
        default:
                break;
        }
@@ -609,6 +610,7 @@ out_err_unmap:
                                break;
                        case SAS_PROTOCOL_SSP:
                                asd_unbuild_ssp_ascb(a);
+                               break;
                        default:
                                break;
                        }