net: qede: flower: validate control flags
authorAsbjørn Sloth Tønnesen <ast@fiberby.net>
Sat, 11 May 2024 07:37:03 +0000 (07:37 +0000)
committerJakub Kicinski <kuba@kernel.org>
Tue, 14 May 2024 00:17:39 +0000 (17:17 -0700)
This driver currently doesn't support any control flags.

Use flow_rule_match_has_control_flags() to check for control flags,
such as can be set through `tc flower ... ip_flags frag`.

In case any control flags are masked, flow_rule_match_has_control_flags()
sets a NL extended error message, and we return -EOPNOTSUPP.

Only compile-tested.

Signed-off-by: Asbjørn Sloth Tønnesen <ast@fiberby.net>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://lore.kernel.org/r/20240511073705.230507-1-ast@fiberby.net
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/qlogic/qede/qede_filter.c

index 9c72febc6a4240020d2b30505bbd1ad6aaaf8c4a..985026dd816fcc7a9ab6e5df0172554c6b355145 100644 (file)
@@ -1848,6 +1848,9 @@ qede_parse_flow_attr(__be16 proto, struct flow_rule *rule,
                return -EOPNOTSUPP;
        }
 
+       if (flow_rule_match_has_control_flags(rule, extack))
+               return -EOPNOTSUPP;
+
        if (proto != htons(ETH_P_IP) &&
            proto != htons(ETH_P_IPV6)) {
                NL_SET_ERR_MSG_FMT_MOD(extack, "Unsupported proto=0x%x",