scsi: pm80xx: Add fatal error checks
authorChangyuan Lyu <changyuanl@google.com>
Fri, 26 May 2023 23:51:55 +0000 (23:51 +0000)
committerMartin K. Petersen <martin.petersen@oracle.com>
Thu, 1 Jun 2023 00:06:53 +0000 (20:06 -0400)
Add fatal error checking for the pm8001_phy_control() and
pm8001_lu_reset() functions.

Signed-off-by: Changyuan Lyu <changyuanl@google.com>
Signed-off-by: Pranav Prasad <pranavpp@google.com>
Link: https://lore.kernel.org/r/20230526235155.433243-1-pranavpp@google.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/pm8001/pm8001_sas.c

index e5673c774f66d7e3be116063fe4a8b31bf55be66..a5a31dfa451228722050c9722bcda79d0a26a813 100644 (file)
@@ -167,6 +167,17 @@ int pm8001_phy_control(struct asd_sas_phy *sas_phy, enum phy_func func,
        pm8001_ha = sas_phy->ha->lldd_ha;
        phy = &pm8001_ha->phy[phy_id];
        pm8001_ha->phy[phy_id].enable_completion = &completion;
+
+       if (PM8001_CHIP_DISP->fatal_errors(pm8001_ha)) {
+               /*
+                * If the controller is in fatal error state,
+                * we will not get a response from the controller
+                */
+               pm8001_dbg(pm8001_ha, FAIL,
+                          "Phy control failed due to fatal errors\n");
+               return -EFAULT;
+       }
+
        switch (func) {
        case PHY_FUNC_SET_LINK_RATE:
                rates = funcdata;
@@ -908,6 +919,17 @@ int pm8001_lu_reset(struct domain_device *dev, u8 *lun)
        struct pm8001_device *pm8001_dev = dev->lldd_dev;
        struct pm8001_hba_info *pm8001_ha = pm8001_find_ha_by_dev(dev);
        DECLARE_COMPLETION_ONSTACK(completion_setstate);
+
+       if (PM8001_CHIP_DISP->fatal_errors(pm8001_ha)) {
+               /*
+                * If the controller is in fatal error state,
+                * we will not get a response from the controller
+                */
+               pm8001_dbg(pm8001_ha, FAIL,
+                          "LUN reset failed due to fatal errors\n");
+               return rc;
+       }
+
        if (dev_is_sata(dev)) {
                struct sas_phy *phy = sas_get_local_phy(dev);
                sas_execute_internal_abort_dev(dev, 0, NULL);