s390/dasd: Move allocation error message to DBF
authorJan Höppner <hoeppner@linux.ibm.com>
Thu, 8 Feb 2024 16:42:43 +0000 (17:42 +0100)
committerJens Axboe <axboe@kernel.dk>
Thu, 8 Feb 2024 17:12:01 +0000 (10:12 -0700)
All error messages for a failling dasd_smalloc_request() call are logged
via DBF, except one. There is no value in logging this particular
allocation failure via dev_err(). Move the message to DBF, too, to be
in line with the rest.

Signed-off-by: Jan Höppner <hoeppner@linux.ibm.com>
Reviewed-by: Stefan Haberland <sth@linux.ibm.com>
Signed-off-by: Stefan Haberland <sth@linux.ibm.com>
Link: https://lore.kernel.org/r/20240208164248.540985-5-sth@linux.ibm.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/s390/block/dasd.c

index a9aa2db3f4abbd92b3672818fecb11532ac21075..79697301fd834cf2e8ccdcfefacc2aa380abf55f 100644 (file)
@@ -3963,10 +3963,8 @@ static struct dasd_ccw_req *dasd_generic_build_rdc(struct dasd_device *device,
                                   NULL);
 
        if (IS_ERR(cqr)) {
-               /* internal error 13 - Allocating the RDC request failed*/
-               dev_err(&device->cdev->dev,
-                        "An error occurred in the DASD device driver, "
-                        "reason=%s\n", "13");
+               DBF_EVENT_DEVID(DBF_WARNING, device->cdev, "%s",
+                               "Could not allocate RDC request");
                return cqr;
        }