btrfs: remove pointless return value assignment at btrfs_finish_one_ordered()
authorFilipe Manana <fdmanana@suse.com>
Tue, 16 Jan 2024 15:05:00 +0000 (15:05 +0000)
committerDavid Sterba <dsterba@suse.com>
Tue, 7 May 2024 19:31:02 +0000 (21:31 +0200)
At btrfs_finish_one_ordered() it's pointless to assign 0 to the 'ret'
variable because if it has a non-zero value (error), we have already
jumped to the 'out' label. So remove that redundant assignment.

Reviewed-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/inode.c

index 12b1a83a43035c2ddc2a45cbf6511c621beb6012..1e19cb34b59a39753b2f0a32e583dc1c2d20938f 100644 (file)
@@ -3184,7 +3184,6 @@ int btrfs_finish_one_ordered(struct btrfs_ordered_extent *ordered_extent)
                btrfs_abort_transaction(trans, ret);
                goto out;
        }
-       ret = 0;
 out:
        clear_extent_bit(&inode->io_tree, start, end, clear_bits,
                         &cached_state);