staging: vc04_services: Remove explicit NULL comparison
authorGargi Sharma <gs051095@gmail.com>
Thu, 23 Feb 2017 20:28:18 +0000 (01:58 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 6 Mar 2017 08:17:02 +0000 (09:17 +0100)
Replace explicit NULL comparison with ! operator to
simplify code.

Found with Coccinelle script:
@@
expression ptr;
position p;
statement s0, s1;
@@

ptr@p =
\(kmalloc\|devm_kzalloc\|kmalloc_array\|devm_ioremap\|usb_alloc_urb\|
alloc_netdev\|dev_alloc_skb\)(...)
... when != ptr

if (
(
+ !
ptr
- == NULL
)
) s0 else s1

Signed-off-by: Gargi Sharma <gs051095@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c

index dc4569e3f578a201882dc69535e2ab1159489d7e..cc4cb168f4837b696f1893cf124f012900788493 100644 (file)
@@ -1590,7 +1590,7 @@ dump_phys_mem(void *virt_addr, u32 num_bytes)
        num_pages = DIV_ROUND_UP(offset + num_bytes, PAGE_SIZE);
 
        pages = kmalloc(sizeof(struct page *) * num_pages, GFP_KERNEL);
-       if (pages == NULL) {
+       if (!pages) {
                vchiq_log_error(vchiq_arm_log_level,
                        "Unable to allocation memory for %d pages\n",
                        num_pages);