pktcdvd: remove a pointless debug check in pkt_submit_bio
authorChristoph Hellwig <hch@lst.de>
Fri, 4 Mar 2022 18:00:58 +0000 (19:00 +0100)
committerJens Axboe <axboe@kernel.dk>
Mon, 7 Mar 2022 13:42:33 +0000 (06:42 -0700)
->queuedata is set up in pkt_init_queue, so it can't be NULL here.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Link: https://lore.kernel.org/r/20220304180105.409765-4-hch@lst.de
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/pktcdvd.c

index be749c686feb735d87690fd812ef0a29e89be2c4..e745fc29e55d8d0452297a4141c94f552ab4e131 100644 (file)
@@ -2400,18 +2400,11 @@ static void pkt_make_request_write(struct request_queue *q, struct bio *bio)
 
 static void pkt_submit_bio(struct bio *bio)
 {
-       struct pktcdvd_device *pd;
-       char b[BDEVNAME_SIZE];
+       struct pktcdvd_device *pd = bio->bi_bdev->bd_disk->queue->queuedata;
        struct bio *split;
 
        blk_queue_split(&bio);
 
-       pd = bio->bi_bdev->bd_disk->queue->queuedata;
-       if (!pd) {
-               pr_err("%s incorrect request queue\n", bio_devname(bio, b));
-               goto end_io;
-       }
-
        pkt_dbg(2, pd, "start = %6llx stop = %6llx\n",
                (unsigned long long)bio->bi_iter.bi_sector,
                (unsigned long long)bio_end_sector(bio));