media: imx: csc/scaler: fix v4l2_ctrl_handler memory leak
authorLucas Stach <l.stach@pengutronix.de>
Wed, 31 Jan 2024 12:00:33 +0000 (13:00 +0100)
committerHans Verkuil <hverkuil-cisco@xs4all.nl>
Fri, 16 Feb 2024 10:46:32 +0000 (11:46 +0100)
Free the memory allocated in v4l2_ctrl_handler_init on release.

Fixes: a8ef0488cc59 ("media: imx: add csc/scaler mem2mem device")
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
drivers/staging/media/imx/imx-media-csc-scaler.c

index 1fd39a2fca98ae70ca74ea3768aeb5d7c95a51da..95cca281e8a378c6244bd25d5b81c392712361aa 100644 (file)
@@ -803,6 +803,7 @@ static int ipu_csc_scaler_release(struct file *file)
 
        dev_dbg(priv->dev, "Releasing instance %p\n", ctx);
 
+       v4l2_ctrl_handler_free(&ctx->ctrl_hdlr);
        v4l2_m2m_ctx_release(ctx->fh.m2m_ctx);
        v4l2_fh_del(&ctx->fh);
        v4l2_fh_exit(&ctx->fh);