drm/xe/query: Increase timestamp width
authorLucas De Marchi <lucas.demarchi@intel.com>
Fri, 11 Oct 2024 03:56:16 +0000 (20:56 -0700)
committerLucas De Marchi <lucas.demarchi@intel.com>
Wed, 16 Oct 2024 14:00:22 +0000 (09:00 -0500)
Starting with Xe2 the timestamp is a full 64 bit counter, contrary to
the 36 bit that was available before. Although 36 should be sufficient
for any reasonable delta calculation (for Xe2, of about 30min), it's
surprising to userspace to get something truncated. Also if the
timestamp being compared to is coming from the GPU and the application
is not careful enough to apply the width there, a delta calculation
would be wrong.

Extend it to full 64-bits starting with Xe2.

v2: Expand width=64 to media gt, as it's just a wrong tagging in the
spec - empirical tests show it goes beyond 36 bits and match the engines
for the main gt

Bspec: 60411
Cc: Szymon Morek <szymon.morek@intel.com>
Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20241011035618.1057602-1-lucas.demarchi@intel.com
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
(cherry picked from commit 9d559cdcb21f42188d4c3ff3b4fe42b240f4af5d)
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
drivers/gpu/drm/xe/xe_query.c

index 28d9bb3b825de9f9b692e29125038874fb20155d..848da8e68c7a8378c65d818f9dff26c8b87186a6 100644 (file)
@@ -161,7 +161,11 @@ query_engine_cycles(struct xe_device *xe,
                          cpu_clock);
 
        xe_force_wake_put(gt_to_fw(gt), XE_FORCEWAKE_ALL);
-       resp.width = 36;
+
+       if (GRAPHICS_VER(xe) >= 20)
+               resp.width = 64;
+       else
+               resp.width = 36;
 
        /* Only write to the output fields of user query */
        if (put_user(resp.cpu_timestamp, &query_ptr->cpu_timestamp))