ASoC: Intel: avs: Replace risky functions with safer variants

strscpy() and snprintf() are the recommended equivalents of their
riskier friends.

Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
Link: https://msgid.link/r/20240405090929.1184068-7-cezary.rojewski@intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>

diff --git a/sound/soc/intel/avs/loader.c b/sound/soc/intel/avs/loader.c
index 8e34d3536082aac69ae11d72748e1a245b0a68b5..57370f0905dc3ca8faa0b95faf7f6655a7c2a9e7 100644 (file)
--- a/sound/soc/intel/avs/loader.c
+++ b/sound/soc/intel/avs/loader.c
@@ -535,7 +535,7 @@ int avs_dsp_load_libraries(struct avs_dev *adev, struct avs_tplg_library *libs,
                if (ret)
                        return ret;
 
-               strncpy(adev->lib_names[id], man->name, AVS_LIB_NAME_SIZE);
+               strscpy(adev->lib_names[id], man->name, AVS_LIB_NAME_SIZE);
                id++;
 next_lib:
                i++;
@@ -698,7 +698,7 @@ int avs_dsp_first_boot_firmware(struct avs_dev *adev)
        }
 
        /* basefw always occupies slot 0 */
-       strcpy(&adev->lib_names[0][0], "BASEFW");
+       strscpy(adev->lib_names[0], "BASEFW", AVS_LIB_NAME_SIZE);
 
        ida_init(&adev->ppl_ida);
 

diff --git a/sound/soc/intel/avs/pcm.c b/sound/soc/intel/avs/pcm.c
index 72f1bc3b7b1fe4d70f866867c773845b5688dcce..405de1d581786570587411d4a26976e4a47ad500 100644 (file)
--- a/sound/soc/intel/avs/pcm.c
+++ b/sound/soc/intel/avs/pcm.c
@@ -1420,7 +1420,7 @@ static void avs_component_hda_unregister_dais(struct snd_soc_component *componen
 
        mach = dev_get_platdata(component->card->dev);
        codec = mach->pdata;
-       sprintf(name, "%s-cpu", dev_name(&codec->core.dev));
+       snprintf(name, sizeof(name), "%s-cpu", dev_name(&codec->core.dev));
 
        for_each_component_dais_safe(component, dai, save) {
                int stream;