net/mlx5e: Remove incorrect addition of action fwd flag
authorRoi Dayan <roid@nvidia.com>
Thu, 12 Aug 2021 06:37:19 +0000 (09:37 +0300)
committerSaeed Mahameed <saeedm@nvidia.com>
Fri, 24 Sep 2021 18:46:52 +0000 (11:46 -0700)
A user is expected to explicit request a fwd or drop action.
It is not correct to implicit add a fwd action for the user,
when modify header action flag exists.

Signed-off-by: Roi Dayan <roid@nvidia.com>
Reviewed-by: Maor Dickman <maord@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
drivers/net/ethernet/mellanox/mlx5/core/en_tc.c

index f55fc8553664bdb9e76993a1788eea76817250b2..d68c67b98d94db1b3fa624eec45f48197bd47a73 100644 (file)
@@ -3491,9 +3491,6 @@ static int parse_tc_nic_actions(struct mlx5e_priv *priv,
                attr->action |= MLX5_FLOW_CONTEXT_ACTION_FWD_DEST;
        }
 
-       if (attr->action & MLX5_FLOW_CONTEXT_ACTION_MOD_HDR)
-               attr->action |= MLX5_FLOW_CONTEXT_ACTION_FWD_DEST;
-
        if (!actions_match_supported(priv, flow_action, parse_attr, flow, extack))
                return -EOPNOTSUPP;