kvm, mm: account kvm related kmem slabs to kmemcg
authorShakeel Butt <shakeelb@google.com>
Fri, 6 Oct 2017 01:07:24 +0000 (18:07 -0700)
committerPaolo Bonzini <pbonzini@redhat.com>
Thu, 12 Oct 2017 12:01:53 +0000 (14:01 +0200)
The kvm slabs can consume a significant amount of system memory
and indeed in our production environment we have observed that
a lot of machines are spending significant amount of memory that
can not be left as system memory overhead. Also the allocations
from these slabs can be triggered directly by user space applications
which has access to kvm and thus a buggy application can leak
such memory. So, these caches should be accounted to kmemcg.

Signed-off-by: Shakeel Butt <shakeelb@google.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
arch/x86/kvm/mmu.c
virt/kvm/kvm_main.c

index 3b7f94715c57a8f36800340da52cfa2f0feccd39..cdedf5320145890111cc8d530a4c628fae07ca52 100644 (file)
@@ -5475,13 +5475,13 @@ int kvm_mmu_module_init(void)
 
        pte_list_desc_cache = kmem_cache_create("pte_list_desc",
                                            sizeof(struct pte_list_desc),
-                                           0, 0, NULL);
+                                           0, SLAB_ACCOUNT, NULL);
        if (!pte_list_desc_cache)
                goto nomem;
 
        mmu_page_header_cache = kmem_cache_create("kvm_mmu_page_header",
                                                  sizeof(struct kvm_mmu_page),
-                                                 0, 0, NULL);
+                                                 0, SLAB_ACCOUNT, NULL);
        if (!mmu_page_header_cache)
                goto nomem;
 
index 9deb5a245b83032ffaa960d42cd6f01ecb614b1b..3d73299e05f2f32b789d4ce62dee5ad2f9c73de1 100644 (file)
@@ -4010,7 +4010,7 @@ int kvm_init(void *opaque, unsigned vcpu_size, unsigned vcpu_align,
        if (!vcpu_align)
                vcpu_align = __alignof__(struct kvm_vcpu);
        kvm_vcpu_cache = kmem_cache_create("kvm_vcpu", vcpu_size, vcpu_align,
-                                          0, NULL);
+                                          SLAB_ACCOUNT, NULL);
        if (!kvm_vcpu_cache) {
                r = -ENOMEM;
                goto out_free_3;