bpf: Simplify the calculation of variables
authorJiapeng Chong <jiapeng.chong@linux.alibaba.com>
Wed, 3 Mar 2021 07:20:35 +0000 (15:20 +0800)
committerAlexei Starovoitov <ast@kernel.org>
Fri, 5 Mar 2021 03:24:53 +0000 (19:24 -0800)
Fix the following coccicheck warnings:

./tools/bpf/bpf_dbg.c:1201:55-57: WARNING !A || A && B is equivalent to
!A || B.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Acked-by: Yonghong Song <yhs@fb.com>
Link: https://lore.kernel.org/bpf/1614756035-111280-1-git-send-email-jiapeng.chong@linux.alibaba.com
tools/bpf/bpf_dbg.c

index a07dfc479270d0cb1335782a0cf5debdc23b0d93..00e560a17baf28de05f114df1aa38945afc71e86 100644 (file)
@@ -1198,7 +1198,7 @@ static int cmd_run(char *num)
                else
                        return CMD_OK;
                bpf_reset();
-       } while (pcap_next_pkt() && (!has_limit || (has_limit && ++i < pkts)));
+       } while (pcap_next_pkt() && (!has_limit || (++i < pkts)));
 
        rl_printf("bpf passes:%u fails:%u\n", pass, fail);