kbuild: pkg: clean up package files/dirs from the top Makefile
authorMasahiro Yamada <yamada.masahiro@socionext.com>
Wed, 21 Aug 2019 07:02:02 +0000 (16:02 +0900)
committerMasahiro Yamada <yamada.masahiro@socionext.com>
Sat, 24 Aug 2019 22:39:21 +0000 (07:39 +0900)
I am not a big fan of the $(objtree)/ hack for clean-files/clean-dirs.

These are created in the top of $(objtree), so let's clean them up
from the top Makefile.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Makefile
scripts/Makefile
scripts/package/Makefile

index db2ddd53d55709af4c999bbf9265112adbbff39f..69cb3ec35d3c50e1eb214c116b6434c585ea64d4 100644 (file)
--- a/Makefile
+++ b/Makefile
@@ -1386,12 +1386,14 @@ CLEAN_FILES += modules.builtin.modinfo
 
 # Directories & files removed with 'make mrproper'
 MRPROPER_DIRS  += include/config include/generated          \
-                 arch/$(SRCARCH)/include/generated .tmp_objdiff
+                 arch/$(SRCARCH)/include/generated .tmp_objdiff \
+                 debian/ snap/ tar-install/
 MRPROPER_FILES += .config .config.old .version \
                  Module.symvers \
                  signing_key.pem signing_key.priv signing_key.x509     \
                  x509.genkey extra_certificates signing_key.x509.keyid \
-                 signing_key.x509.signer vmlinux-gdb.py
+                 signing_key.x509.signer vmlinux-gdb.py \
+                 *.spec
 
 # Directories & files removed with 'make distclean'
 DISTCLEAN_DIRS  +=
index 16bcb80878997cfe91a52231ec0b315451201244..c42891e10ba30ddfc896b8710b6bdf8de9798833 100644 (file)
@@ -36,4 +36,4 @@ subdir-$(CONFIG_MODVERSIONS) += genksyms
 subdir-$(CONFIG_SECURITY_SELINUX) += selinux
 
 # Let clean descend into subdirs
-subdir-        += basic dtc gdb kconfig mod package
+subdir-        += basic dtc gdb kconfig mod
index ca7f46b562a4ffe68337eb9b367b108bf0c6bbea..a2d8830f54be498a621f0e371faba7e164c881bb 100644 (file)
@@ -65,8 +65,6 @@ binrpm-pkg: FORCE
        +rpmbuild $(RPMOPTS) --define "_builddir $(objtree)" --target \
                $(UTS_MACHINE) -bb $(objtree)/binkernel.spec
 
-clean-files += $(objtree)/*.spec
-
 deb-pkg: FORCE
        $(MAKE) clean
        $(CONFIG_SHELL) $(srctree)/scripts/package/mkdebian
@@ -82,8 +80,6 @@ bindeb-pkg: FORCE
 intdeb-pkg: FORCE
        +$(CONFIG_SHELL) $(srctree)/scripts/package/builddeb
 
-clean-dirs += $(objtree)/debian/
-
 # snap-pkg
 # ---------------------------------------------------------------------------
 snap-pkg: FORCE
@@ -98,17 +94,12 @@ snap-pkg: FORCE
        cd $(objtree)/snap && \
        snapcraft --target-arch=$(UTS_MACHINE)
 
-clean-dirs += $(objtree)/snap/
-
 # tarball targets
 # ---------------------------------------------------------------------------
 tar%pkg: FORCE
        $(MAKE) -f $(srctree)/Makefile
        +$(CONFIG_SHELL) $(srctree)/scripts/package/buildtar $@
 
-clean-dirs += $(objtree)/tar-install/
-
-
 # perf-pkg - generate a source tarball with perf source
 # ---------------------------------------------------------------------------