auxdisplay/cfag12864bfb.c: Convert to use vm_map_pages_zero()
authorSouptick Joarder <jrdr.linux@gmail.com>
Sun, 26 May 2019 16:10:27 +0000 (21:40 +0530)
committerMiguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Thu, 20 Jun 2019 13:06:17 +0000 (15:06 +0200)
While using mmap, the incorrect values of length and vm_pgoff are
ignored and this driver goes ahead with mapping cfag12864b_buffer
to user vma.

Convert vm_insert_pages() to use vm_map_pages_zero(). We could later
"fix" these drivers to behave according to the normal vm_pgoff
offsetting simply by removing the _zero suffix on the function name and
if that causes regressions, it gives us an easy way to revert.

Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
Signed-off-by: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
drivers/auxdisplay/cfag12864bfb.c

index 40c8a552a478e7e7b8818788e22e57f7ba7ec427..4074886b7bc85b9dc9ab438081b82bba134e953c 100644 (file)
@@ -52,8 +52,9 @@ static const struct fb_var_screeninfo cfag12864bfb_var = {
 
 static int cfag12864bfb_mmap(struct fb_info *info, struct vm_area_struct *vma)
 {
-       return vm_insert_page(vma, vma->vm_start,
-               virt_to_page(cfag12864b_buffer));
+       struct page *pages = virt_to_page(cfag12864b_buffer);
+
+       return vm_map_pages_zero(vma, &pages, 1);
 }
 
 static struct fb_ops cfag12864bfb_ops = {