HID: hid-sensor-custom: Convert sprintf() family to sysfs_emit() family
authorLi Zhijian <lizhijian@fujitsu.com>
Tue, 19 Mar 2024 05:45:25 +0000 (13:45 +0800)
committerJiri Kosina <jkosina@suse.com>
Wed, 3 Apr 2024 11:42:04 +0000 (13:42 +0200)
Per filesystems/sysfs.rst, show() should only use sysfs_emit()
or sysfs_emit_at() when formatting the value to be returned to user space.

coccinelle complains that there are still a couple of functions that use
snprintf(). Convert them to sysfs_emit().

sprintf() and scnprintf() will be converted as well if they have.

Generally, this patch is generated by
make coccicheck M=<path/to/file> MODE=patch \
COCCI=scripts/coccinelle/api/device_attr_show.cocci

No functional change intended

CC: Jiri Kosina <jikos@kernel.org>
CC: Jonathan Cameron <jic23@kernel.org>
CC: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
CC: Benjamin Tissoires <benjamin.tissoires@redhat.com>
CC: linux-input@vger.kernel.org
CC: linux-iio@vger.kernel.org
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
drivers/hid/hid-sensor-custom.c

index d85398721659ab6ac90ddb9e48fea4c89fd90e38..ac214777d7d9452c202d0e4d0970a08063ed11f8 100644 (file)
@@ -155,7 +155,7 @@ static ssize_t enable_sensor_show(struct device *dev,
 {
        struct hid_sensor_custom *sensor_inst = dev_get_drvdata(dev);
 
-       return sprintf(buf, "%d\n", sensor_inst->enable);
+       return sysfs_emit(buf, "%d\n", sensor_inst->enable);
 }
 
 static int set_power_report_state(struct hid_sensor_custom *sensor_inst,
@@ -372,14 +372,13 @@ static ssize_t show_value(struct device *dev, struct device_attribute *attr,
                                     sizeof(struct hid_custom_usage_desc),
                                     usage_id_cmp);
                if (usage_desc)
-                       return snprintf(buf, PAGE_SIZE, "%s\n",
-                                       usage_desc->desc);
+                       return sysfs_emit(buf, "%s\n", usage_desc->desc);
                else
-                       return sprintf(buf, "not-specified\n");
+                       return sysfs_emit(buf, "not-specified\n");
         } else
                return -EINVAL;
 
-       return sprintf(buf, "%d\n", value);
+       return sysfs_emit(buf, "%d\n", value);
 }
 
 static ssize_t store_value(struct device *dev, struct device_attribute *attr,