sfc: remove efx_writed_page_locked
authorAndy Moreton <andy.moreton@amd.com>
Wed, 18 Dec 2024 13:59:30 +0000 (13:59 +0000)
committerJakub Kicinski <kuba@kernel.org>
Fri, 20 Dec 2024 03:14:39 +0000 (19:14 -0800)
From: Andy Moreton <andy.moreton@amd.com>

efx_writed_page_locked is a workaround for Siena hardware that is not
needed on later adapters, and has no callers. Remove it.

Signed-off-by: Andy Moreton <andy.moreton@amd.com>
Signed-off-by: Edward Cree <ecree.xilinx@gmail.com>
Link: https://patch.msgid.link/20241218135930.2350358-1-edward.cree@amd.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/sfc/io.h

index 4cc7b501135fb542e6880c8cac4b98e6abec8ada..ef374a8e05c39cbe009cdd0cf97f068a3172a66c 100644 (file)
@@ -217,28 +217,4 @@ _efx_writed_page(struct efx_nic *efx, const efx_dword_t *value,
                                           (reg) != 0xa1c),             \
                         page)
 
-/* Write TIMER_COMMAND.  This is a page-mapped 32-bit CSR, but a bug
- * in the BIU means that writes to TIMER_COMMAND[0] invalidate the
- * collector register.
- */
-static inline void _efx_writed_page_locked(struct efx_nic *efx,
-                                          const efx_dword_t *value,
-                                          unsigned int reg,
-                                          unsigned int page)
-{
-       unsigned long flags __attribute__ ((unused));
-
-       if (page == 0) {
-               spin_lock_irqsave(&efx->biu_lock, flags);
-               efx_writed(efx, value, efx_paged_reg(efx, page, reg));
-               spin_unlock_irqrestore(&efx->biu_lock, flags);
-       } else {
-               efx_writed(efx, value, efx_paged_reg(efx, page, reg));
-       }
-}
-#define efx_writed_page_locked(efx, value, reg, page)                  \
-       _efx_writed_page_locked(efx, value,                             \
-                               reg + BUILD_BUG_ON_ZERO((reg) != 0x420), \
-                               page)
-
 #endif /* EFX_IO_H */