staging: r8188eu: fix warnings in rtw_wlan_util
authorVihas Makwana <makvihas@gmail.com>
Tue, 17 May 2022 14:06:26 +0000 (19:36 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 19 May 2022 15:44:43 +0000 (17:44 +0200)
Refactor the code to fix following warnings:
    WARNING: Comparisons should place the constant on the right side of the test
    CHECK: Comparison to NULL could be written "p"

Signed-off-by: Vihas Makwana <makvihas@gmail.com>
Link: https://lore.kernel.org/r/20220517140626.3716-4-makvihas@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/r8188eu/core/rtw_wlan_util.c

index 7caf6a4a4d1755528707e8458d5d948c02288619..392a65783f3248b226c005f66d01bc2ae80cf61f 100644 (file)
@@ -964,7 +964,7 @@ int rtw_check_bcn_info(struct adapter  *Adapter, u8 *pframe, u32 packet_len)
        else
                hidden_ssid = false;
 
-       if ((NULL != p) && (false == hidden_ssid && (*(p + 1)))) {
+       if (p && (!hidden_ssid && (*(p + 1)))) {
                memcpy(bssid->Ssid.Ssid, (p + 2), *(p + 1));
                bssid->Ssid.SsidLength = *(p + 1);
        } else {