drm/bridge/sii8620: fix dependency on extcon
authorRobert Foss <robert.foss@linaro.org>
Mon, 19 Apr 2021 09:01:24 +0000 (11:01 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 14 Jul 2021 14:56:14 +0000 (16:56 +0200)
[ Upstream commit 08319adbdde15ef7cee1970336f63461254baa2a ]

The DRM_SIL_SII8620 kconfig has a weak `imply` dependency
on EXTCON, which causes issues when sii8620 is built
as a builtin and EXTCON is built as a module.

The symptoms are 'undefined reference' errors caused
by the symbols in EXTCON not being available
to the sii8620 driver.

Fixes: 688838442147 ("drm/bridge/sii8620: use micro-USB cable detection logic to detect MHL")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Robert Foss <robert.foss@linaro.org>
Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20210419090124.153560-1-robert.foss@linaro.org
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/bridge/Kconfig

index e145cbb35baca760b28342967f36490393893a2e..4e82647a621eff4e5434fd7210c589dcdf6690a6 100644 (file)
@@ -130,7 +130,7 @@ config DRM_SIL_SII8620
        tristate "Silicon Image SII8620 HDMI/MHL bridge"
        depends on OF
        select DRM_KMS_HELPER
-       imply EXTCON
+       select EXTCON
        depends on RC_CORE || !RC_CORE
        help
          Silicon Image SII8620 HDMI/MHL bridge chip driver.