net: fec: check DMA addressing limitations

Check DMA addressing limitations as suggested by the DMA API
how-to. This does not fix a particular issue seen but is
considered good style.

Signed-off-by: Stefan Agner <stefan@agner.ch>
Acked-by: Fugang Duan <fugang.duan@nxp.com>
Reviewed-by: Robin Murphy <robin.murphy@arm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
index 98ad341922558d2e632d2b66edb2398677bb6bf4..76366c73583124eaae79bf2594a9517f92675087 100644 (file)
--- a/drivers/net/ethernet/freescale/fec_main.c
+++ b/drivers/net/ethernet/freescale/fec_main.c
@@ -3129,6 +3129,7 @@ static int fec_enet_init(struct net_device *ndev)
        unsigned dsize = fep->bufdesc_ex ? sizeof(struct bufdesc_ex) :
                        sizeof(struct bufdesc);
        unsigned dsize_log2 = __fls(dsize);
+       int ret;
 
        WARN_ON(dsize != (1 << dsize_log2));
 #if defined(CONFIG_ARM) || defined(CONFIG_ARM64)
@@ -3139,6 +3140,13 @@ static int fec_enet_init(struct net_device *ndev)
        fep->tx_align = 0x3;
 #endif
 
+       /* Check mask of the streaming and coherent API */
+       ret = dma_set_mask_and_coherent(&fep->pdev->dev, DMA_BIT_MASK(32));
+       if (ret < 0) {
+               dev_warn(&fep->pdev->dev, "No suitable DMA available\n");
+               return ret;
+       }
+
        fec_enet_alloc_queue(ndev);
 
        bd_size = (fep->total_tx_ring_size + fep->total_rx_ring_size) * dsize;