ethernet: hisilicon: hns: hns_dsaf_main: add missing of_node_put after calling of_par...
authorPeter Chen <peter.chen@nxp.com>
Mon, 1 Aug 2016 07:02:35 +0000 (15:02 +0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 2 Aug 2016 04:43:48 +0000 (21:43 -0700)
of_node_put needs to be called when the device node which is got
from of_parse_phandle has finished using.

Signed-off-by: Peter Chen <peter.chen@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c

index 2ef4277d00b3167edc029f8ff5921048a5da8e1e..afb5daa3721d2162c3fe134c4716e551e0153ddd 100644 (file)
@@ -51,7 +51,7 @@ int hns_dsaf_get_cfg(struct dsaf_device *dsaf_dev)
        const char *mode_str;
        struct regmap *syscon;
        struct resource *res;
-       struct device_node *np = dsaf_dev->dev->of_node;
+       struct device_node *np = dsaf_dev->dev->of_node, *np_temp;
        struct platform_device *pdev = to_platform_device(dsaf_dev->dev);
 
        if (dev_of_node(dsaf_dev->dev)) {
@@ -102,8 +102,9 @@ int hns_dsaf_get_cfg(struct dsaf_device *dsaf_dev)
                dsaf_dev->dsaf_tc_mode = HRD_DSAF_4TC_MODE;
 
        if (dev_of_node(dsaf_dev->dev)) {
-               syscon = syscon_node_to_regmap(
-                               of_parse_phandle(np, "subctrl-syscon", 0));
+               np_temp = of_parse_phandle(np, "subctrl-syscon", 0);
+               syscon = syscon_node_to_regmap(np_temp);
+               of_node_put(np_temp);
                if (IS_ERR_OR_NULL(syscon)) {
                        res = platform_get_resource(pdev, IORESOURCE_MEM,
                                                    res_idx++);