mmc: sdhci-esdhc-mcf: Flag the sg_miter as atomic

The sg_miter used to loop over the returned sglist from a
transfer in the esdhc subdriver for SDHCI can be called
from atomic context so the miter needs to be atomic.

sdhci_request_done() is always called from process context,
either as a work or as part of the threaded interrupt handler,
but the one case when we are actually calling .request_done()
from an atomic context is in sdhci_irq().

Fix this by flagging the miter atomic so we always use
kmap_atomic().

Fixes: e8a167b84886 ("mmc: sdhci-esdhc-mcf: Use sg_miter for swapping")
Reported-by: Adrian Hunter <adrian.hunter@intel.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
Link: https://lore.kernel.org/r/20240228-fix-sdhci-esdhc-mcf-2-v2-1-4ebb3fd691ea@linaro.org
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>

diff --git a/drivers/mmc/host/sdhci-esdhc-mcf.c b/drivers/mmc/host/sdhci-esdhc-mcf.c
index 1909a11fd0653748a8a560757b26c1df8bd4c6d4..c97363e2d86cd2d62c6e4854893e421abe7d1048 100644 (file)
--- a/drivers/mmc/host/sdhci-esdhc-mcf.c
+++ b/drivers/mmc/host/sdhci-esdhc-mcf.c
@@ -313,7 +313,7 @@ static void esdhc_mcf_request_done(struct sdhci_host *host,
         * transfer endiannes. A swap after the transfer is needed.
         */
        sg_miter_start(&sgm, mrq->data->sg, mrq->data->sg_len,
-                      SG_MITER_TO_SG | SG_MITER_FROM_SG);
+                      SG_MITER_ATOMIC | SG_MITER_TO_SG | SG_MITER_FROM_SG);
        while (sg_miter_next(&sgm)) {
                buffer = sgm.addr;
                esdhc_mcf_buffer_swap32(buffer, sgm.length);