wifi: wl3501_cs: don't call kfree_skb() under spin_lock_irqsave()
authorYang Yingliang <yangyingliang@huawei.com>
Wed, 7 Dec 2022 15:04:53 +0000 (23:04 +0800)
committerKalle Valo <kvalo@kernel.org>
Thu, 22 Dec 2022 16:14:33 +0000 (18:14 +0200)
It is not allowed to call kfree_skb() from hardware interrupt
context or with interrupts being disabled. So replace kfree_skb()
with dev_kfree_skb_irq() under spin_lock_irqsave(). Compile
tested only.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20221207150453.114742-1-yangyingliang@huawei.com
drivers/net/wireless/wl3501_cs.c

index 1b532e00a56fb6a6490dd048cdd2810e32d1cd94..7fb2f95134760094ae9e61c8e6f54f98e66c6442 100644 (file)
@@ -1328,7 +1328,7 @@ static netdev_tx_t wl3501_hard_start_xmit(struct sk_buff *skb,
        } else {
                ++dev->stats.tx_packets;
                dev->stats.tx_bytes += skb->len;
-               kfree_skb(skb);
+               dev_kfree_skb_irq(skb);
 
                if (this->tx_buffer_cnt < 2)
                        netif_stop_queue(dev);