drivers: net: phy: xgene: Fix 'remove' function
authorChristophe Jaillet <christophe.jaillet@wanadoo.fr>
Sun, 11 Sep 2016 19:43:34 +0000 (21:43 +0200)
committerDavid S. Miller <davem@davemloft.net>
Tue, 13 Sep 2016 16:04:11 +0000 (12:04 -0400)
If 'IS_ERR(pdata->clk)' is true, then 'clk_disable_unprepare(pdata->clk)'
will do nothing.

It is likely that 'if (!IS_ERR(pdata->clk))' was expected here.
In fact, the test can even be removed because 'clk_disable_unprepare'
already handles such cases.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/phy/mdio-xgene.c

index 775674808249eb56fa0eb4087745b930b0bef411..92af182951bec5cc0c6374242ec2a59570c6e40b 100644 (file)
@@ -424,10 +424,8 @@ static int xgene_mdio_remove(struct platform_device *pdev)
        mdiobus_unregister(mdio_bus);
        mdiobus_free(mdio_bus);
 
-       if (dev->of_node) {
-               if (IS_ERR(pdata->clk))
-                       clk_disable_unprepare(pdata->clk);
-       }
+       if (dev->of_node)
+               clk_disable_unprepare(pdata->clk);
 
        return 0;
 }