gpu: ipu-v3: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert the ipu-v3 platform drivers from always returning zero
in the remove callback to the void returning variant.

Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
Link: https://lore.kernel.org/r/dee3c0e1c8c6bd1027a91c65be55ac1d6ba9e099.1712681770.git.u.kleine-koenig@pengutronix.de
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

diff --git a/drivers/gpu/ipu-v3/ipu-common.c b/drivers/gpu/ipu-v3/ipu-common.c
index 71ec1e7f657adbaa2de385860e5896f657a0adcd..3535be9daa1f39ab00ddfda4898f6f97c6308dab 100644 (file)
--- a/drivers/gpu/ipu-v3/ipu-common.c
+++ b/drivers/gpu/ipu-v3/ipu-common.c
@@ -1450,7 +1450,7 @@ out_failed_reset:
        return ret;
 }
 
-static int ipu_remove(struct platform_device *pdev)
+static void ipu_remove(struct platform_device *pdev)
 {
        struct ipu_soc *ipu = platform_get_drvdata(pdev);
 
@@ -1459,8 +1459,6 @@ static int ipu_remove(struct platform_device *pdev)
        ipu_irq_exit(ipu);
 
        clk_disable_unprepare(ipu->clk);
-
-       return 0;
 }
 
 static struct platform_driver imx_ipu_driver = {
@@ -1469,7 +1467,7 @@ static struct platform_driver imx_ipu_driver = {
                .of_match_table = imx_ipu_dt_ids,
        },
        .probe = ipu_probe,
-       .remove = ipu_remove,
+       .remove_new = ipu_remove,
 };
 
 static struct platform_driver * const drivers[] = {

diff --git a/drivers/gpu/ipu-v3/ipu-pre.c b/drivers/gpu/ipu-v3/ipu-pre.c
index aef984a431901739ca0a7ec9a94ddc9ba63e9b99..e469272d4f257f2d731a80d5ba901a9c7bb7eb95 100644 (file)
--- a/drivers/gpu/ipu-v3/ipu-pre.c
+++ b/drivers/gpu/ipu-v3/ipu-pre.c
@@ -312,7 +312,7 @@ static int ipu_pre_probe(struct platform_device *pdev)
        return 0;
 }
 
-static int ipu_pre_remove(struct platform_device *pdev)
+static void ipu_pre_remove(struct platform_device *pdev)
 {
        struct ipu_pre *pre = platform_get_drvdata(pdev);
 
@@ -326,7 +326,6 @@ static int ipu_pre_remove(struct platform_device *pdev)
        if (pre->buffer_virt)
                gen_pool_free(pre->iram, (unsigned long)pre->buffer_virt,
                              IPU_PRE_MAX_WIDTH * IPU_PRE_NUM_SCANLINES * 4);
-       return 0;
 }
 
 static const struct of_device_id ipu_pre_dt_ids[] = {
@@ -336,7 +335,7 @@ static const struct of_device_id ipu_pre_dt_ids[] = {
 
 struct platform_driver ipu_pre_drv = {
        .probe          = ipu_pre_probe,
-       .remove         = ipu_pre_remove,
+       .remove_new     = ipu_pre_remove,
        .driver         = {
                .name   = "imx-ipu-pre",
                .of_match_table = ipu_pre_dt_ids,

diff --git a/drivers/gpu/ipu-v3/ipu-prg.c b/drivers/gpu/ipu-v3/ipu-prg.c
index 72960570995590cdb5ed4aff4120f30d4d339109..4976ac0bb87660608929cec4acec8a7a61579b21 100644 (file)
--- a/drivers/gpu/ipu-v3/ipu-prg.c
+++ b/drivers/gpu/ipu-v3/ipu-prg.c
@@ -419,15 +419,13 @@ static int ipu_prg_probe(struct platform_device *pdev)
        return 0;
 }
 
-static int ipu_prg_remove(struct platform_device *pdev)
+static void ipu_prg_remove(struct platform_device *pdev)
 {
        struct ipu_prg *prg = platform_get_drvdata(pdev);
 
        mutex_lock(&ipu_prg_list_mutex);
        list_del(&prg->list);
        mutex_unlock(&ipu_prg_list_mutex);
-
-       return 0;
 }
 
 #ifdef CONFIG_PM
@@ -471,7 +469,7 @@ static const struct of_device_id ipu_prg_dt_ids[] = {
 
 struct platform_driver ipu_prg_drv = {
        .probe          = ipu_prg_probe,
-       .remove         = ipu_prg_remove,
+       .remove_new     = ipu_prg_remove,
        .driver         = {
                .name   = "imx-ipu-prg",
                .pm     = &prg_pm_ops,