firmware: tegra: Switch to global mrq_is_supported()
authorTimo Alho <talho@nvidia.com>
Mon, 22 Oct 2018 13:19:37 +0000 (16:19 +0300)
committerThierry Reding <treding@nvidia.com>
Thu, 8 Nov 2018 11:49:25 +0000 (12:49 +0100)
Patch "firmware: tegra: add helper to check for supported MRQs" added
an API to check if MRQ is supported. Remove the implementation from
bpmp debugfs code in favor of that.

Signed-off-by: Timo Alho <talho@nvidia.com>
Acked-by: Sivaram Nair <sivaramn@nvidia.com>
Acked-by: Jon Hunter <jonathanh@nvidia.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>
drivers/firmware/tegra/bpmp-debugfs.c

index f7f6a0a5cb0786081669756c66abc7036475d539..a84df1a8ca2b83e3630cd9d557262eeb29f04a3e 100644 (file)
@@ -379,33 +379,6 @@ static int create_debugfs_mirror(struct tegra_bpmp *bpmp, void *buf,
        return err;
 }
 
-static int mrq_is_supported(struct tegra_bpmp *bpmp, unsigned int mrq)
-{
-       struct mrq_query_abi_request req = { .mrq = cpu_to_le32(mrq) };
-       struct mrq_query_abi_response resp;
-       struct tegra_bpmp_message msg = {
-               .mrq = MRQ_QUERY_ABI,
-               .tx = {
-                       .data = &req,
-                       .size = sizeof(req),
-               },
-               .rx = {
-                       .data = &resp,
-                       .size = sizeof(resp),
-               },
-       };
-       int ret;
-
-       ret = tegra_bpmp_transfer(bpmp, &msg);
-       if (ret < 0) {
-               /* something went wrong; assume not supported */
-               dev_warn(bpmp->dev, "tegra_bpmp_transfer failed (%d)\n", ret);
-               return 0;
-       }
-
-       return resp.status ? 0 : 1;
-}
-
 int tegra_bpmp_init_debugfs(struct tegra_bpmp *bpmp)
 {
        dma_addr_t phys;
@@ -415,7 +388,7 @@ int tegra_bpmp_init_debugfs(struct tegra_bpmp *bpmp)
        int ret;
        struct dentry *root;
 
-       if (!mrq_is_supported(bpmp, MRQ_DEBUGFS))
+       if (!tegra_bpmp_mrq_is_supported(bpmp, MRQ_DEBUGFS))
                return 0;
 
        root = debugfs_create_dir("bpmp", NULL);