net: phy: use network device in phy_print_status
authorFlorian Fainelli <f.fainelli@gmail.com>
Wed, 12 Feb 2014 01:27:33 +0000 (17:27 -0800)
committerDavid S. Miller <davem@davemloft.net>
Thu, 13 Feb 2014 00:08:19 +0000 (19:08 -0500)
phy_print_status() currently uses dev_name(&phydev->dev) which will
usually result in printing something along those lines for Device Tree
aware drivers:

libphy: f0b60000.etherne:0a - Link is Down
libphy: f0ba0000.etherne:00 - Link is Up - 1000/Full

This is not terribly useful for network administrators or users since we
expect a network interface name to be able to correlate link events with
interfaces. Update phy_print_status() to use netdev_info() with
phydev->attached_dev which is the backing network device for our PHY
device. The leading dash is removed since netdev_info() prefixes the
messages with "<interface>: " already.

Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/phy/phy.c

index 19c9eca0ef2638165dc9dc087d87aee934d28348..c35b2e73168ab10e3d6aeb2f79bf92824755dae0 100644 (file)
 void phy_print_status(struct phy_device *phydev)
 {
        if (phydev->link) {
-               pr_info("%s - Link is Up - %d/%s\n",
-                       dev_name(&phydev->dev),
+               netdev_info(phydev->attached_dev, "Link is Up - %d/%s\n",
                        phydev->speed,
                        DUPLEX_FULL == phydev->duplex ? "Full" : "Half");
        } else  {
-               pr_info("%s - Link is Down\n", dev_name(&phydev->dev));
+               netdev_info(phydev->attached_dev, "Link is Down\n");
        }
 }
 EXPORT_SYMBOL(phy_print_status);