bluetooth: btmrvl_sdio: Replace GFP_ATOMIC with GFP_KERNEL in btmrvl_sdio_card_to_host()
authorJia-Ju Bai <baijiaju1990@gmail.com>
Mon, 23 Jul 2018 03:30:03 +0000 (11:30 +0800)
committerMarcel Holtmann <marcel@holtmann.org>
Mon, 23 Jul 2018 16:05:00 +0000 (18:05 +0200)
btmrvl_sdio_card_to_host() is never called in atomic context.
It calls bt_skb_alloc() with GFP_ATOMIC, which is not necessary.
GFP_ATOMIC can be replaced with GFP_KERNEL.

This is found by a static analysis tool named DCNS written by myself.
I also manually check the kernel code before reporting it.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
drivers/bluetooth/btmrvl_sdio.c

index 888bac49a87bd8a5f2afdde0c9f947ef8e146817..fb3d03928460281b751b0634ee022e42b163230b 100644 (file)
@@ -718,7 +718,7 @@ static int btmrvl_sdio_card_to_host(struct btmrvl_private *priv)
        }
 
        /* Allocate buffer */
-       skb = bt_skb_alloc(num_blocks * blksz + BTSDIO_DMA_ALIGN, GFP_ATOMIC);
+       skb = bt_skb_alloc(num_blocks * blksz + BTSDIO_DMA_ALIGN, GFP_KERNEL);
        if (!skb) {
                BT_ERR("No free skb");
                ret = -ENOMEM;