solos: Slight debugging improvements
authorSimon Farnsworth <simon@farnz.org.uk>
Mon, 19 Jan 2009 21:19:29 +0000 (21:19 +0000)
committerDavid Woodhouse <David.Woodhouse@intel.com>
Tue, 27 Jan 2009 03:18:17 +0000 (14:18 +1100)
Print a message if pskb_expand_head fails.

Make atmdebug writable by root, so that you can turn printing of data sent to
and received from the card on and off at runtime - useful for tracking
corruption.

Signed-off-by: Simon Farnsworth <simon@farnz.org.uk>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
drivers/atm/solos-pci.c

index f0309546c356192a1381fe1d6a4a90e1d8553486..3daa3a3743131dab6957c4d79c24a75f99006bae 100644 (file)
@@ -91,7 +91,7 @@ MODULE_LICENSE("GPL");
 MODULE_PARM_DESC(debug, "Enable Loopback");
 MODULE_PARM_DESC(atmdebug, "Print ATM data");
 module_param(debug, int, 0444);
-module_param(atmdebug, int, 0444);
+module_param(atmdebug, int, 0644);
 
 static int opens;
 
@@ -541,6 +541,7 @@ static int psend(struct atm_vcc *vcc, struct sk_buff *skb)
 
                ret = pskb_expand_head(skb, expand_by, 0, GFP_ATOMIC);
                if (ret) {
+                       dev_warn(&card->dev->dev, "pskb_expand_head failed.\n");
                        solos_pop(vcc, skb);
                        return ret;
                }