ASoC: soc-dapm.c: don't use WARN_ON() at snd_soc_dai_link_event_pre_pmu()
authorKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Mon, 5 Sep 2022 23:17:43 +0000 (23:17 +0000)
committerMark Brown <broonie@kernel.org>
Wed, 7 Sep 2022 11:44:30 +0000 (12:44 +0100)
Current snd_soc_dai_link_event_pre_pmu() is checking "config".
It is using dev_err() (A) if it was NULL, so we don't need to use
WARN_ON() (B) to check it, it is over-kill. This patch removes it.

(B) if (WARN_ON(!config)) {
(A) dev_err(...);
...
}

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/87zgfd8l7s.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/soc-dapm.c

index 73b8bd452ca753df41eeb795077a6b2ca42d1563..02924395ed867314821b7195f53c831ff518764c 100644 (file)
@@ -3885,7 +3885,7 @@ snd_soc_dai_link_event_pre_pmu(struct snd_soc_dapm_widget *w,
         * necessary
         */
        config = rtd->dai_link->params + rtd->params_select;
-       if (WARN_ON(!config)) {
+       if (!config) {
                dev_err(w->dapm->dev, "ASoC: link config missing\n");
                ret = -EINVAL;
                goto out;