ntb_perf: Delete duplicate dmaengine_unmap_put() call in perf_copy_chunk()
authorMarkus Elfring <elfring@users.sourceforge.net>
Mon, 23 Sep 2024 08:38:11 +0000 (10:38 +0200)
committerJon Mason <jdmason@kudzu.us>
Tue, 18 Mar 2025 14:33:39 +0000 (10:33 -0400)
The function call “dmaengine_unmap_put(unmap)” was used in an if branch.
The same call was immediately triggered by a subsequent goto statement.
Thus avoid such a call repetition.

This issue was detected by using the Coccinelle software.

Fixes: 5648e56d03fa ("NTB: ntb_perf: Add full multi-port NTB API support")
Cc: stable@vger.kernel.org
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Jon Mason <jdmason@kudzu.us>
drivers/ntb/test/ntb_perf.c

index 72bc1d017a46eea394ef3dbebb6e9f0bb9d4a312..dfd175f79e8f087576625fc787e2bc0b402a279f 100644 (file)
@@ -839,10 +839,8 @@ static int perf_copy_chunk(struct perf_thread *pthr,
        dma_set_unmap(tx, unmap);
 
        ret = dma_submit_error(dmaengine_submit(tx));
-       if (ret) {
-               dmaengine_unmap_put(unmap);
+       if (ret)
                goto err_free_resource;
-       }
 
        dmaengine_unmap_put(unmap);