net: pktgen: fix code style (WARNING: Prefer strscpy over strcpy)

Fix checkpatch code style warnings:

  WARNING: Prefer strscpy over strcpy - see: https://github.com/KSPP/linux/issues/88
  #1423: FILE: net/core/pktgen.c:1423:
  +                       strcpy(pkt_dev->dst_min, buf);

  WARNING: Prefer strscpy over strcpy - see: https://github.com/KSPP/linux/issues/88
  #1444: FILE: net/core/pktgen.c:1444:
  +                       strcpy(pkt_dev->dst_max, buf);

  WARNING: Prefer strscpy over strcpy - see: https://github.com/KSPP/linux/issues/88
  #1554: FILE: net/core/pktgen.c:1554:
  +                       strcpy(pkt_dev->src_min, buf);

  WARNING: Prefer strscpy over strcpy - see: https://github.com/KSPP/linux/issues/88
  #1575: FILE: net/core/pktgen.c:1575:
  +                       strcpy(pkt_dev->src_max, buf);

  WARNING: Prefer strscpy over strcpy - see: https://github.com/KSPP/linux/issues/88
  #3231: FILE: net/core/pktgen.c:3231:
  +                       strcpy(pkt_dev->result, "Starting");

  WARNING: Prefer strscpy over strcpy - see: https://github.com/KSPP/linux/issues/88
  #3235: FILE: net/core/pktgen.c:3235:
  +                       strcpy(pkt_dev->result, "Error starting");

  WARNING: Prefer strscpy over strcpy - see: https://github.com/KSPP/linux/issues/88
  #3849: FILE: net/core/pktgen.c:3849:
  +       strcpy(pkt_dev->odevname, ifname);

While at it squash memset/strcpy pattern into single strscpy_pad call.

Signed-off-by: Peter Seiderer <ps.report@gmx.net>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20250415112916.113455-4-ps.report@gmx.net
Signed-off-by: Paolo Abeni <pabeni@redhat.com>

diff --git a/net/core/pktgen.c b/net/core/pktgen.c
index 9d56f9765411f65bc6de6844215596c1a8881ccc..0ebe5461d4d967d8bbc252718e487789e3921da9 100644 (file)
--- a/net/core/pktgen.c
+++ b/net/core/pktgen.c
@@ -1419,8 +1419,7 @@ static ssize_t pktgen_if_write(struct file *file,
                        return -EFAULT;
                buf[len] = 0;
                if (strcmp(buf, pkt_dev->dst_min) != 0) {
-                       memset(pkt_dev->dst_min, 0, sizeof(pkt_dev->dst_min));
-                       strcpy(pkt_dev->dst_min, buf);
+                       strscpy_pad(pkt_dev->dst_min, buf);
                        pkt_dev->daddr_min = in_aton(pkt_dev->dst_min);
                        pkt_dev->cur_daddr = pkt_dev->daddr_min;
                }
@@ -1440,8 +1439,7 @@ static ssize_t pktgen_if_write(struct file *file,
                        return -EFAULT;
                buf[len] = 0;
                if (strcmp(buf, pkt_dev->dst_max) != 0) {
-                       memset(pkt_dev->dst_max, 0, sizeof(pkt_dev->dst_max));
-                       strcpy(pkt_dev->dst_max, buf);
+                       strscpy_pad(pkt_dev->dst_max, buf);
                        pkt_dev->daddr_max = in_aton(pkt_dev->dst_max);
                        pkt_dev->cur_daddr = pkt_dev->daddr_max;
                }
@@ -1550,8 +1548,7 @@ static ssize_t pktgen_if_write(struct file *file,
                        return -EFAULT;
                buf[len] = 0;
                if (strcmp(buf, pkt_dev->src_min) != 0) {
-                       memset(pkt_dev->src_min, 0, sizeof(pkt_dev->src_min));
-                       strcpy(pkt_dev->src_min, buf);
+                       strscpy_pad(pkt_dev->src_min, buf);
                        pkt_dev->saddr_min = in_aton(pkt_dev->src_min);
                        pkt_dev->cur_saddr = pkt_dev->saddr_min;
                }
@@ -1571,8 +1568,7 @@ static ssize_t pktgen_if_write(struct file *file,
                        return -EFAULT;
                buf[len] = 0;
                if (strcmp(buf, pkt_dev->src_max) != 0) {
-                       memset(pkt_dev->src_max, 0, sizeof(pkt_dev->src_max));
-                       strcpy(pkt_dev->src_max, buf);
+                       strscpy_pad(pkt_dev->src_max, buf);
                        pkt_dev->saddr_max = in_aton(pkt_dev->src_max);
                        pkt_dev->cur_saddr = pkt_dev->saddr_max;
                }
@@ -3228,11 +3224,11 @@ static void pktgen_run(struct pktgen_thread *t)
 
                        set_pkt_overhead(pkt_dev);
 
-                       strcpy(pkt_dev->result, "Starting");
+                       strscpy(pkt_dev->result, "Starting");
                        pkt_dev->running = 1;   /* Cranke yeself! */
                        started++;
                } else
-                       strcpy(pkt_dev->result, "Error starting");
+                       strscpy(pkt_dev->result, "Error starting");
        }
        rcu_read_unlock();
        if (started)
@@ -3846,7 +3842,7 @@ static int pktgen_add_device(struct pktgen_thread *t, const char *ifname)
        if (!pkt_dev)
                return -ENOMEM;
 
-       strcpy(pkt_dev->odevname, ifname);
+       strscpy(pkt_dev->odevname, ifname);
        pkt_dev->flows = vzalloc_node(array_size(MAX_CFLOWS,
                                                 sizeof(struct flow_state)),
                                      node);