drm/xe: fix HuC FW ordering for DG1
authorDaniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Tue, 27 Jun 2023 22:28:56 +0000 (15:28 -0700)
committerRodrigo Vivi <rodrigo.vivi@intel.com>
Thu, 21 Dec 2023 16:35:05 +0000 (11:35 -0500)
The firmware definitions must be ordered based on platform, from newer
to older, which means that the DG1 FW must come before the ADL one.

Link: https://gitlab.freedesktop.org/drm/intel/-/issues/8699
Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Reviewed-by: Matthew Brost <matthew.brost@intel.com>
Link: https://lore.kernel.org/r/20230627222856.3165647-1-daniele.ceraolospurio@intel.com
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
drivers/gpu/drm/xe/xe_uc_fw.c

index 2b9b9b4a67115e526b529c2dfbae1ec1a936a88f..bc63c0d3e33ab83140077cf6b3fdc508fc36d545 100644 (file)
@@ -111,9 +111,9 @@ struct fw_blobs_by_type {
        fw_def(TIGERLAKE,       major_ver(i915, guc,    tgl,    70, 5))
 
 #define XE_HUC_FIRMWARE_DEFS(fw_def, mmp_ver, no_ver)                          \
+       fw_def(DG1,             no_ver(i915,    huc,    dg1))                   \
        fw_def(ALDERLAKE_P,     no_ver(i915,    huc,    tgl))                   \
        fw_def(ALDERLAKE_S,     no_ver(i915,    huc,    tgl))                   \
-       fw_def(DG1,             no_ver(i915,    huc,    dg1))                   \
        fw_def(ROCKETLAKE,      no_ver(i915,    huc,    tgl))                   \
        fw_def(TIGERLAKE,       no_ver(i915,    huc,    tgl))