power: supply: twl4030_charger: remove incorrect __exit markups
authorDmitry Torokhov <dmitry.torokhov@gmail.com>
Wed, 1 Mar 2017 23:44:53 +0000 (15:44 -0800)
committerSebastian Reichel <sre@kernel.org>
Thu, 13 Apr 2017 23:41:33 +0000 (01:41 +0200)
Even if bus is not hot-pluggable, the devices can be unbound from the
driver via sysfs, so we should not be using __exit annotations on
remove() methods. The only exception is drivers registered with
platform_driver_probe() which specifically disables sysfs bind/unbind
attributes.

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Sebastian Reichel <sre@kernel.org>
drivers/power/supply/twl4030_charger.c

index bcd4dc304f270c50739e2b2ddfc2850e1efe3bf0..990ff3d218bcc7572bd1be15da7731fd36894736 100644 (file)
@@ -1117,7 +1117,7 @@ fail:
        return ret;
 }
 
-static int __exit twl4030_bci_remove(struct platform_device *pdev)
+static int twl4030_bci_remove(struct platform_device *pdev)
 {
        struct twl4030_bci *bci = platform_get_drvdata(pdev);
 
@@ -1148,11 +1148,11 @@ MODULE_DEVICE_TABLE(of, twl_bci_of_match);
 
 static struct platform_driver twl4030_bci_driver = {
        .probe = twl4030_bci_probe,
+       .remove = twl4030_bci_remove,
        .driver = {
                .name   = "twl4030_bci",
                .of_match_table = of_match_ptr(twl_bci_of_match),
        },
-       .remove = __exit_p(twl4030_bci_remove),
 };
 module_platform_driver(twl4030_bci_driver);