perf test demangle-java: Switch to using dso__demangle_sym()
authorIan Rogers <irogers@google.com>
Wed, 30 Apr 2025 00:41:27 +0000 (17:41 -0700)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Fri, 9 May 2025 20:02:23 +0000 (17:02 -0300)
The use of the demangle-java APIs means we don't detect if a different
demangler is used before the Java one for the case that matters to
perf.

Remove the return types from the demangled names as dso__demangle_sym()
removes those.

Signed-off-by: Ian Rogers <irogers@google.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alex Gaynor <alex.gaynor@gmail.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Alice Ryhl <aliceryhl@google.com>
Cc: Andreas Hindborg <a.hindborg@kernel.org>
Cc: Ariel Ben-Yehuda <ariel.byd@gmail.com>
Cc: Benno Lossin <benno.lossin@proton.me>
Cc: Bill Wendling <morbo@google.com>
Cc: Björn Roy Baron <bjorn3_gh@protonmail.com>
Cc: Boqun Feng <boqun.feng@gmail.com>
Cc: Daniel Xu <dxu@dxuuu.xyz>
Cc: Danilo Krummrich <dakr@kernel.org>
Cc: Gary Guo <gary@garyguo.net>
Cc: Howard Chu <howardchu95@gmail.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: James Clark <james.clark@linaro.org>
Cc: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Justin Stitt <justinstitt@google.com>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Miguel Ojeda <ojeda@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Nathan Chancellor <nathan@kernel.org>
Cc: Nick Desaulniers <nick.desaulniers+lkml@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Ravi Bangoria <ravi.bangoria@amd.com>
Cc: Stephen Brennan <stephen.s.brennan@oracle.com>
Cc: Trevor Gross <tmgross@umich.edu>
Link: https://lore.kernel.org/r/20250430004128.474388-6-irogers@google.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/tests/demangle-java-test.c

index 93c94408bdc8f046a4f5c54fcefa252578d72619..ebaf60cdfa99fe897dc3561f467d2bb5b0d83d20 100644 (file)
@@ -3,10 +3,9 @@
 #include <stdlib.h>
 #include <stdio.h>
 #include <linux/kernel.h>
-#include "tests.h"
-#include "session.h"
 #include "debug.h"
-#include "demangle-java.h"
+#include "symbol.h"
+#include "tests.h"
 
 static int test__demangle_java(struct test_suite *test __maybe_unused, int subtest __maybe_unused)
 {
@@ -18,19 +17,19 @@ static int test__demangle_java(struct test_suite *test __maybe_unused, int subte
                const char *mangled, *demangled;
        } test_cases[] = {
                { "Ljava/lang/StringLatin1;equals([B[B)Z",
-                 "boolean java.lang.StringLatin1.equals(byte[], byte[])" },
+                 "java.lang.StringLatin1.equals(byte[], byte[])" },
                { "Ljava/util/zip/ZipUtils;CENSIZ([BI)J",
-                 "long java.util.zip.ZipUtils.CENSIZ(byte[], int)" },
+                 "java.util.zip.ZipUtils.CENSIZ(byte[], int)" },
                { "Ljava/util/regex/Pattern$BmpCharProperty;match(Ljava/util/regex/Matcher;ILjava/lang/CharSequence;)Z",
-                 "boolean java.util.regex.Pattern$BmpCharProperty.match(java.util.regex.Matcher, int, java.lang.CharSequence)" },
+                 "java.util.regex.Pattern$BmpCharProperty.match(java.util.regex.Matcher, int, java.lang.CharSequence)" },
                { "Ljava/lang/AbstractStringBuilder;appendChars(Ljava/lang/String;II)V",
-                 "void java.lang.AbstractStringBuilder.appendChars(java.lang.String, int, int)" },
+                 "java.lang.AbstractStringBuilder.appendChars(java.lang.String, int, int)" },
                { "Ljava/lang/Object;<init>()V",
-                 "void java.lang.Object<init>()" },
+                 "java.lang.Object<init>()" },
        };
 
        for (i = 0; i < ARRAY_SIZE(test_cases); i++) {
-               buf = java_demangle_sym(test_cases[i].mangled, 0);
+               buf = dso__demangle_sym(/*dso=*/NULL, /*kmodule=*/0, test_cases[i].mangled);
                if (strcmp(buf, test_cases[i].demangled)) {
                        pr_debug("FAILED: %s: %s != %s\n", test_cases[i].mangled,
                                 buf, test_cases[i].demangled);