selftests/net: only print passing message in GRO tests when tests pass
authorKevin Krakauer <krakauer@google.com>
Wed, 26 Feb 2025 19:27:24 +0000 (11:27 -0800)
committerJakub Kicinski <kuba@kernel.org>
Fri, 28 Feb 2025 02:38:23 +0000 (18:38 -0800)
gro.c:main no longer erroneously claims a test passes when running as a
sender.

Tested: Ran `gro.sh -t large` to verify the sender no longer prints a
status.

Signed-off-by: Kevin Krakauer <krakauer@google.com>
Reviewed-by: Willem de Bruijn <willemb@google.com>
Link: https://patch.msgid.link/20250226192725.621969-3-krakauer@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
tools/testing/selftests/net/gro.c

index b2184847e3881275576a91e9be082eb066929b32..d5824eadea1093cfb5d1dc5551af64783ce22f29 100644 (file)
@@ -1318,11 +1318,13 @@ int main(int argc, char **argv)
        read_MAC(src_mac, smac);
        read_MAC(dst_mac, dmac);
 
-       if (tx_socket)
+       if (tx_socket) {
                gro_sender();
-       else
+       } else {
+               /* Only the receiver exit status determines test success. */
                gro_receiver();
+               fprintf(stderr, "Gro::%s test passed.\n", testname);
+       }
 
-       fprintf(stderr, "Gro::%s test passed.\n", testname);
        return 0;
 }