net: usb: lan78xx: Simplify lan78xx_update_reg
authorOleksij Rempel <o.rempel@pengutronix.de>
Mon, 9 Dec 2024 13:07:45 +0000 (14:07 +0100)
committerJakub Kicinski <kuba@kernel.org>
Wed, 11 Dec 2024 02:50:58 +0000 (18:50 -0800)
Simplify `lan78xx_update_reg` by directly returning the result of
`lan78xx_write_reg`. This eliminates unnecessary checks and improves
code readability.

Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://patch.msgid.link/20241209130751.703182-6-o.rempel@pengutronix.de
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/usb/lan78xx.c

index 5d318ff8b33deecf2395aa8ed88352a6cad0f891..442b6ee2dd46174ffbe5d9f1c13b3b1214207970 100644 (file)
@@ -674,11 +674,7 @@ static int lan78xx_update_reg(struct lan78xx_net *dev, u32 reg, u32 mask,
        buf &= ~mask;
        buf |= (mask & data);
 
-       ret = lan78xx_write_reg(dev, reg, buf);
-       if (ret < 0)
-               return ret;
-
-       return 0;
+       return lan78xx_write_reg(dev, reg, buf);
 }
 
 static int lan78xx_read_stats(struct lan78xx_net *dev,