staging: gpib: Using struct gpib_ppoll_config_ioctl`

Using Linux code style for 'struct gpib_ppoll_config_ioctl' to remove typedef.

Adhering to Linux code style.

Reported by checkpatch.pl

In general, a pointer, or a struct that has elements that can reasonably be
directly accessed should never be a typedef.

Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250409055903.321438-13-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/gpib/common/gpib_os.c b/drivers/staging/gpib/common/gpib_os.c
index aa6e07b1f73d662b29595893765ff85ab2fe5845..9e4ed6262afedf2a753a337eb6eb263f73116c0f 100644 (file)
--- a/drivers/staging/gpib/common/gpib_os.c
+++ b/drivers/staging/gpib/common/gpib_os.c
@@ -1692,7 +1692,7 @@ static int timeout_ioctl(struct gpib_board *board, unsigned long arg)
 
 static int ppc_ioctl(struct gpib_board *board, unsigned long arg)
 {
-       ppoll_config_ioctl_t cmd;
+       struct gpib_ppoll_config_ioctl cmd;
        int retval;
 
        retval = copy_from_user(&cmd, (void __user *)arg, sizeof(cmd));

diff --git a/drivers/staging/gpib/uapi/gpib_ioctl.h b/drivers/staging/gpib/uapi/gpib_ioctl.h
index 5681a66483a8d1c32c6bbe56bee4b1b761f482f8..df428899ba3fe437767af451a16d7ea16183df96 100644 (file)
--- a/drivers/staging/gpib/uapi/gpib_ioctl.h
+++ b/drivers/staging/gpib/uapi/gpib_ioctl.h
@@ -86,11 +86,11 @@ struct gpib_select_pci_ioctl {
        int pci_slot;
 };
 
-typedef struct {
+struct gpib_ppoll_config_ioctl {
        uint8_t config;
        unsigned set_ist : 1;
        unsigned clear_ist : 1;
-}      ppoll_config_ioctl_t;
+};
 
 typedef struct {
        unsigned int handle;
@@ -147,7 +147,7 @@ enum gpib_ioctl {
 
        IBMUTEX = _IOW(GPIB_CODE, 26, int),
        IBSPOLL_BYTES = _IOWR(GPIB_CODE, 27, struct gpib_spoll_bytes_ioctl),
-       IBPPC = _IOW(GPIB_CODE, 28, ppoll_config_ioctl_t),
+       IBPPC = _IOW(GPIB_CODE, 28, struct gpib_ppoll_config_ioctl),
        IBBOARD_INFO = _IOR(GPIB_CODE, 29, struct gpib_board_info_ioctl),
 
        IBQUERY_BOARD_RSV = _IOR(GPIB_CODE, 31, int),