iolog: fix Error handling issues (NEGATIVE_RETURNS)
authorHyunwoo Park <dshw.park@samsung.com>
Thu, 30 May 2024 02:48:57 +0000 (02:48 +0000)
committerHyunwoo Park <dshw.park@samsung.com>
Fri, 31 May 2024 10:08:09 +0000 (10:08 +0000)
CID 494151: Error handling issues (NEGATIVE_RETURNS) @ io_u.c:1877 in get_io_u()
This patch removes negative returns from dp_init() to ensure
its value can be properly consumed by td_verror()

Signed-off-by: Hyunwoo Park <dshw.park@samsung.com>
iolog.c

diff --git a/iolog.c b/iolog.c
index e3a56db9573328196fccf27d04ccbe4f0e50d01b..b57f845e275e04fbe76c39cdc987c1bb2269d83e 100644 (file)
--- a/iolog.c
+++ b/iolog.c
@@ -145,7 +145,7 @@ static int ipo_special(struct thread_data *td, struct io_piece *ipo)
                                int dp_init_ret = dp_init(td);
 
                                if (dp_init_ret != 0) {
-                                       td_verror(td, dp_init_ret, "dp_init");
+                                       td_verror(td, abs(dp_init_ret), "dp_init");
                                        return -1;
                                }
                        }