gpio: sim: use devm_mutex_init()
authorBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Mon, 10 Jun 2024 14:05:48 +0000 (16:05 +0200)
committerBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Tue, 11 Jun 2024 19:38:42 +0000 (21:38 +0200)
Drop the hand-coded devres action callback for destroying the mutex in
favor of devm_mutex_init().

Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Link: https://lore.kernel.org/r/20240610140548.35358-4-brgl@bgdev.pl
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
drivers/gpio/gpio-sim.c

index 21ad8d87ef043f08deabd29ec5a9e24c1d85bc4d..4157735ea7910c597c35739b3c3d69bd72b10a54 100644 (file)
@@ -308,13 +308,6 @@ static ssize_t gpio_sim_sysfs_pull_store(struct device *dev,
        return len;
 }
 
-static void gpio_sim_mutex_destroy(void *data)
-{
-       struct mutex *lock = data;
-
-       mutex_destroy(lock);
-}
-
 static void gpio_sim_put_device(void *data)
 {
        struct device *dev = data;
@@ -458,9 +451,7 @@ static int gpio_sim_add_bank(struct fwnode_handle *swnode, struct device *dev)
        if (ret)
                return ret;
 
-       mutex_init(&chip->lock);
-       ret = devm_add_action_or_reset(dev, gpio_sim_mutex_destroy,
-                                      &chip->lock);
+       ret = devm_mutex_init(dev, &chip->lock);
        if (ret)
                return ret;