md: bcache: check the return value of kzalloc() in detached_dev_do_request()
authorJia-Ju Bai <baijiaju1990@gmail.com>
Fri, 27 May 2022 15:28:18 +0000 (23:28 +0800)
committerJens Axboe <axboe@kernel.dk>
Fri, 27 May 2022 15:49:48 +0000 (09:49 -0600)
The function kzalloc() in detached_dev_do_request() can fail, so its
return value should be checked.

Fixes: bc082a55d25c ("bcache: fix inaccurate io state for detached bcache devices")
Reported-by: TOTE Robot <oslab@tsinghua.edu.cn>
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Coly Li <colyli@suse.de>
Link: https://lore.kernel.org/r/20220527152818.27545-4-colyli@suse.de
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/md/bcache/request.c

index e27f67f06a428727c2929a48da9485b03c0501b5..566838b40f10b98526fbc6355db04cba2cd01c26 100644 (file)
@@ -1105,6 +1105,12 @@ static void detached_dev_do_request(struct bcache_device *d, struct bio *bio,
         * which would call closure_get(&dc->disk.cl)
         */
        ddip = kzalloc(sizeof(struct detached_dev_io_private), GFP_NOIO);
+       if (!ddip) {
+               bio->bi_status = BLK_STS_RESOURCE;
+               bio->bi_end_io(bio);
+               return;
+       }
+
        ddip->d = d;
        /* Count on the bcache device */
        ddip->orig_bdev = orig_bdev;