projects
/
linux-block.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
bfff5d8
)
net: ag71xx: remove always true branch
author
Rosen Penev
<rosenp@gmail.com>
Thu, 5 Sep 2024 19:49:37 +0000
(12:49 -0700)
committer
Jakub Kicinski
<kuba@kernel.org>
Tue, 10 Sep 2024 00:17:39 +0000
(17:17 -0700)
The opposite of this condition is checked above and if true, function
returns. Which means this can never be false.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Reviewed-by: Oleksij Rempel <o.rempel@pengutronix.de>
Link:
https://patch.msgid.link/20240905194938.8453-7-rosenp@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/atheros/ag71xx.c
patch
|
blob
|
blame
|
history
diff --git
a/drivers/net/ethernet/atheros/ag71xx.c
b/drivers/net/ethernet/atheros/ag71xx.c
index a32a72fa4179343f0155d442321311a40fb5d8eb..e28a4b018b1189c9ed6eb52f0bdcbf2c2c8270ba 100644
(file)
--- a/
drivers/net/ethernet/atheros/ag71xx.c
+++ b/
drivers/net/ethernet/atheros/ag71xx.c
@@
-719,12
+719,10
@@
static int ag71xx_mdio_probe(struct ag71xx *ag)
mii_bus->parent = dev;
snprintf(mii_bus->id, MII_BUS_ID_SIZE, "%s.%d", np->name, ag->mac_idx);
- if (!IS_ERR(mdio_reset)) {
- reset_control_assert(mdio_reset);
- msleep(100);
- reset_control_deassert(mdio_reset);
- msleep(200);
- }
+ reset_control_assert(mdio_reset);
+ msleep(100);
+ reset_control_deassert(mdio_reset);
+ msleep(200);
mnp = of_get_child_by_name(np, "mdio");
err = devm_of_mdiobus_register(dev, mii_bus, mnp);