cifsd: enclose macro variables in parenthesis
authorHyunchul Lee <hyc.lee@gmail.com>
Sat, 29 May 2021 13:46:53 +0000 (22:46 +0900)
committerNamjae Jeon <namjae.jeon@samsung.com>
Mon, 31 May 2021 04:48:29 +0000 (13:48 +0900)
checkpatch.pl complains as the following:

CHECK: Macro argument 'fp' may be better as '(fp)' to avoid
precedence issues.

Signed-off-by: Hyunchul Lee <hyc.lee@gmail.com>
Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/cifsd/vfs_cache.h

index 823fcb257a42c0940266ad0e332e9f2509ceb44c..635eedbd497cb5efd5a888e9af7f7728e4e2ffb8 100644 (file)
 #define KSMBD_NO_FID           (UINT_MAX)
 #define SMB2_NO_FID            (0xFFFFFFFFFFFFFFFFULL)
 
-#define FP_FILENAME(fp)                fp->filp->f_path.dentry->d_name.name
-#define FP_INODE(fp)           d_inode(fp->filp->f_path.dentry)
-#define PARENT_INODE(fp)       d_inode(fp->filp->f_path.dentry->d_parent)
-
-#define ATTR_FP(fp) (fp->attrib_only && \
-               (fp->cdoption != FILE_OVERWRITE_IF_LE && \
-               fp->cdoption != FILE_OVERWRITE_LE && \
-               fp->cdoption != FILE_SUPERSEDE_LE))
+#define FP_FILENAME(fp)                ((fp)->filp->f_path.dentry->d_name.name)
+#define FP_INODE(fp)           d_inode((fp)->filp->f_path.dentry)
+#define PARENT_INODE(fp)       d_inode((fp)->filp->f_path.dentry->d_parent)
+
+#define ATTR_FP(fp) ((fp)->attrib_only && \
+                    ((fp)->cdoption != FILE_OVERWRITE_IF_LE && \
+                     (fp)->cdoption != FILE_OVERWRITE_LE && \
+                     (fp)->cdoption != FILE_SUPERSEDE_LE))
 
 struct ksmbd_conn;
 struct ksmbd_session;